Fix some time issues by ldecicco-USGS · Pull Request #854 · DOI-USGS/dataRetrieval

ldecicco-USGS · 2026-02-02T18:37:17Z

Should now allow this:

start <- "2025-10-01"
> end <- Sys.Date()
> dataRetrieval:::format_api_dates(c(start, end), date = TRUE)
[1] "2025-10-01/2026-02-02"

(which fixes #853 )

and this:

dataRetrieval:::format_api_dates(c("2010-01-01T00:00Z", "2010-01-01T05:00Z"))
[1] "2010-01-01T00:00:00Z/2010-01-01T05:00:00Z"

(which fixes #839 )

Fix link

…e to remind myself.

… in the "textVersion" when we do the next official release.

ehinman · 2026-02-06T15:20:56Z

R/construct_api_requests.R

Does this need to be changed to date?

Actually, I think it should be changed to logical (because it tells the code whether or not to return a date or dateTime)

Oh, I meant the input is named "date" and it is logical, right?

ehinman · 2026-02-06T15:37:53Z

R/construct_api_requests.R

+
+  if(length(datetime) == 1){
+    # If the user has "P" or the "/" we assume they know what they are doing
+    if(grepl("P", datetime, ignore.case = TRUE) |


FYI, I tried this with a lowercase "p7d" and "p7D" and the API will not have it. I don't think there's necessarily anything you need to do here, just a random test.

we can plop a toupper in there, good to know!

ehinman

This looks good. Approved. I particularly love this implementation:

start_end <- as.POSIXct(c("2021-01-01 12:15:00",
"2022-01-01 16:45"),
tz = "America/New_York")

dataRetrieval::format_api_dates(start_end)

Very nice.

A couple thoughts/suggestions that are optional: The function documentation for time, begin, and end don't go into detail on the range of dates that the functions will accept. Is this intentional?

In the Water Data APIs vignette, it does a few things with the time input, and there's a section that covers the time zone reference table, but it might be nice to show off using UTC offsets in an example, or the really lovely time zone example I highlight above, where you don't have to futz with offsets at all.

ldecicco-USGS · 2026-02-10T19:05:05Z

This looks good. Approved. I particularly love this implementation:

start_end <- as.POSIXct(c("2021-01-01 12:15:00", "2022-01-01 16:45"), tz = "America/New_York")

dataRetrieval::format_api_dates(start_end)

Very nice.

A couple thoughts/suggestions that are optional: The function documentation for time, begin, and end don't go into detail on the range of dates that the functions will accept. Is this intentional?

In the Water Data APIs vignette, it does a few things with the time input, and there's a section that covers the time zone reference table, but it might be nice to show off using UTC offsets in an example, or the really lovely time zone example I highlight above, where you don't have to futz with offsets at all.

I added a Detail section:

Details
You can also use a vector of length 2 for any time queries (such as time or last_modified). The first value is the starting date (or datetime), the second value is the ending date(or datetime). NA's within the vector indicate a half-bound date. For example, time = c("2024-01-01", NA) will return all data starting at 2024-01-01. time = c(NA, "2024-01-01") will return all data from the beginning of the timeseries until 2024-01-01. By default, time is assumed UTC, although time zone attributes will be accommodated. As an example, setting time = as.POSIXct(c("2021-01-01 12:00:00", "2021-01-01 12:00"), tz = "America/New_York") will request data that between noon and 2pm eastern time on 2021-01-01. All time values RETURNED from the service are UTC with the exception of daily data, which returns time values in local dates.

Let me know if you have any suggestions to fix that.

ehinman · 2026-02-10T19:55:11Z

R/read_waterdata_daily.R

 #' @param approval_status `r get_ogc_params("daily")$approval_status`
 #' @param last_modified `r get_ogc_params("daily")$last_modified`
+#' 
+#' See also Details below for more information.


These don't all have Details, right?

Line 49 below:

#' @inherit read_waterdata_continuous details

Brings the same "Detail" paragraph into other functions' help page

Ahhhh ok, neat. Thanks for sharing that.

ehinman · 2026-02-10T19:55:58Z

R/read_waterdata_continuous.R

+#' the timeseries until 2024-01-01.
+#' By default, time is assumed UTC, although time zone attributes
+#' will be accommodated. As an example, setting \code{time = as.POSIXct(c("2021-01-01 12:00:00",
+#' "2021-01-01 12:00"), tz = "America/New_York")} will request data that between


2:00, not 12:00.

ehinman · 2026-02-10T19:57:24Z

NEWS

 * Added tests for read_waterdata_stats functions
 * Updated next_req_url to allow paging through /statistics API output
-* Added deprecate message to readNWISstat function.
+* Added deprecate message to readNWISstat function


"deprecation"? I don't know why github isn't letting me direct edit things now. Maybe because I approved?

ehinman · 2026-02-10T19:58:24Z

Details looks good besides small typo that I made a comment about.

ldecicco-USGS added 4 commits January 23, 2026 12:44

Fix link

10ad022

Merge pull request DOI-USGS#852 from ldecicco-USGS/main

269cea2

Fix link

fix some date issues

0193308

cleaner

a41a9d1

ldecicco-USGS had a problem deploying to CI_config February 2, 2026 18:37 — with GitHub Actions Failure

Removed bad test because it assumes a local timezone. Kept it in ther…

db921fc

…e to remind myself.

ldecicco-USGS had a problem deploying to CI_config February 2, 2026 18:52 — with GitHub Actions Failure

another implied tz

5f93f39

ldecicco-USGS temporarily deployed to CI_config February 2, 2026 19:05 — with GitHub Actions Inactive

dur

2afa35d

ldecicco-USGS had a problem deploying to CI_config February 3, 2026 15:50 — with GitHub Actions Failure

ldecicco-USGS had a problem deploying to CI_config February 3, 2026 16:32 — with GitHub Actions Failure

ldecicco-USGS temporarily deployed to CI_config February 4, 2026 14:10 — with GitHub Actions Inactive

ldecicco-USGS requested a review from ehinman February 4, 2026 15:13

ldecicco-USGS added 3 commits February 5, 2026 07:47

Merge branch 'develop' of github.com:DOI-USGS/dataRetrieval into develop

37496fd

Up the version and add Joe. We need to remember to update the authors…

6ad31b0

… in the "textVersion" when we do the next official release.

updates from roxygen

30619ad

ldecicco-USGS temporarily deployed to CI_config February 5, 2026 13:51 — with GitHub Actions Inactive

Add link

f5b245e

ldecicco-USGS temporarily deployed to CI_config February 5, 2026 14:29 — with GitHub Actions Inactive

ldecicco-USGS added 2 commits February 5, 2026 09:25

Pretty up the bands

d45209b

More cleanup

e97c3fc

ehinman reviewed Feb 6, 2026

View reviewed changes

update param comments

aad430c

ldecicco-USGS temporarily deployed to CI_config February 6, 2026 15:33 — with GitHub Actions Inactive

ehinman reviewed Feb 6, 2026

View reviewed changes

ehinman approved these changes Feb 6, 2026

View reviewed changes

Merge branch 'main' of github.com:DOI-USGS/dataRetrieval into develop

e1919fa

ldecicco-USGS temporarily deployed to CI_config February 9, 2026 13:55 — with GitHub Actions Inactive

update status

e2e6e34

ldecicco-USGS temporarily deployed to CI_config February 9, 2026 18:26 — with GitHub Actions Inactive

add UTC tz

ac61e82

ldecicco-USGS temporarily deployed to CI_config February 9, 2026 22:45 — with GitHub Actions Inactive

ldecicco-USGS added 2 commits February 10, 2026 08:02

last modified

39f8208

update docs

bad5428

ldecicco-USGS temporarily deployed to CI_config February 10, 2026 14:04 — with GitHub Actions Inactive

Update docs

1043d24

ldecicco-USGS had a problem deploying to CI_config February 10, 2026 18:19 — with GitHub Actions Failure

bump version?

0963952

ldecicco-USGS had a problem deploying to CI_config February 10, 2026 18:32 — with GitHub Actions Failure

ehinman reviewed Feb 10, 2026

View reviewed changes

typo

9515c0b

ldecicco-USGS temporarily deployed to CI_config February 10, 2026 20:42 — with GitHub Actions Inactive

ldecicco-USGS merged commit a21564b into DOI-USGS:develop Feb 10, 2026
1 check passed

Conversation

ldecicco-USGS commented Feb 2, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ehinman left a comment

Choose a reason for hiding this comment

Uh oh!

ldecicco-USGS commented Feb 10, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ehinman commented Feb 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants